Skip to content

feat: Add option to assign field-selector and label-selector#193

Merged
rowansmithau merged 1 commit into
coder:mainfrom
samiulsaki:feature/enable-option-field-label-selector
Jun 16, 2026
Merged

feat: Add option to assign field-selector and label-selector#193
rowansmithau merged 1 commit into
coder:mainfrom
samiulsaki:feature/enable-option-field-label-selector

Conversation

@samiulsaki

Copy link
Copy Markdown
Contributor

Add option to assign field-selector and label-selector for filtering pods to listen events from, instead of adding coder namespaces in the .values.namespaces: [] list

  • Setting fieldSelector: "some-label" will assign this label to environment variables: CODER_FIELD_SELECTOR for the deployment
  • Setting labelSelector: "some-label" will assign this label to environment variables: CODER_LABEL_SELECTOR for the deployment

Relates to: #192

@samiulsaki samiulsaki marked this pull request as ready for review April 28, 2026 07:18

@rowansmithau rowansmithau left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@samiulsaki after seeing your PR I just created & merged #196 as the env vars weren't actually present, however I can't tell what is happening with your PR / why the required checks seem to be not displaying anything. I'm starting a review of it to see if it kicks it into gear

@rowansmithau rowansmithau marked this pull request as draft June 16, 2026 04:53
@rowansmithau rowansmithau marked this pull request as ready for review June 16, 2026 04:54
@rowansmithau rowansmithau reopened this Jun 16, 2026
@rowansmithau rowansmithau merged commit 7dbe94a into coder:main Jun 16, 2026
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants